Merged
Conversation
Created using spr 1.3.6-beta.1
smklein
approved these changes
Apr 4, 2025
Contributor
Author
|
We had a look at the changes between now and zip 2.6.0 and decided to accept this, though the semver breakages like zip-rs/zip2#328 are a bit concerning. |
sunshowers
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jun 24, 2025
zip 2.6.x was yanked, which causes r-a in Omicron to be somewhat sad (see oxidecomputer/tufaceous#31 for example output). Along with omicron, we also pull in updates to tufaceous and support-bundle-viewer. The versions were yanked due to breaking semver (and republished as zip version 3 and 4), but we already made our code compatible with zip 2.6 (oxidecomputer/tufaceous#25) so this upgrade involves no code changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The performance regression identified in earlier versions of zip appears to
have been addressed by zip-rs/zip2#247.